allow minimal installed system without libzypp#2512
Merged
Conversation
jreidinger
force-pushed
the
only_required_sles
branch
from
319bb88 to
63e41e0
Compare
mvidner
reviewed
Jun 26, 2025
Contributor
mvidner
left a comment
mvidner
left a comment
There was a problem hiding this comment.
The main question is: is the missing libzypp a feature, or a bug? We still haven't confirmed which is the case.
Contributor
Author
|
@mvidner according to https://suse.slack.com/archives/C082VE1U2F5/p1750842000769769?thread_ts=1750758112.536869&cid=C082VE1U2F5 I would say it is backward compatible with SLE15 where libzypp is not mandatory on target system. Of course there are ways for users how to add it like sw_management pattern or directly in list of packages. So I would say missing libzypp is feature that was already in SLE15 ( just maybe yast cannot do it? not sure ) |
Contributor
Author
|
BTW I am off today, so when approved, feel free to merge |
imobachgs
reviewed
Jun 26, 2025
Contributor
imobachgs
left a comment
imobachgs
left a comment
There was a problem hiding this comment.
The part about skipping the tests in CI looks good.
lslezak
approved these changes
Jun 26, 2025
Merged
imobachgs
added a commit
that referenced
this pull request
Jun 30, 2025
Prepare to release Agama 16: * #1868 * #2347 * #2356 * #2373 * #2393 * #2402 * #2404 * #2406 * #2408 * #2409 * #2410 * #2411 * #2412 * #2413 * #2414 * #2415 * #2416 * #2417 * #2418 * #2419 * #2420 * #2421 * #2422 * #2423 * #2424 * #2425 * #2426 * #2427 * #2428 * #2431 * #2433 * #2434 * #2436 * #2437 * #2438 * #2439 * #2440 * #2441 * #2442 * #2443 * #2445 * #2446 * #2450 * #2451 * #2452 * #2453 * #2454 * #2455 * #2456 * #2457 * #2458 * #2460 * #2461 * #2462 * #2463 * #2464 * #2465 * #2466 * #2467 * #2468 * #2469 * #2470 * #2471 * #2472 * #2473 * #2474 * #2475 * #2476 * #2478 * #2479 * #2480 * #2482 * #2483 * #2484 * #2485 * #2487 * #2488 * #2489 * #2490 * #2491 * #2493 * #2494 * #2495 * #2496 * #2497 * #2498 * #2499 * #2502 * #2505 * #2507 * #2509 * #2511 * #2512 * #2513 * #2515 * #2516 * #2517 * #2518 * #2520 * #2523 * #2524 * #2525
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For SLES16 the minimal system can be without libzypp (Confirmed with Frederic Crozat). If it is case together with
onlyRequiresflag, then software service crashes when trying to loadzypp.conf.Solution
Add check if file exists and if not, just log it and continue.
Also change as agreed modification of zypp.conf to explicitly write onlyRequires if user explicitly mention it in profile to not just use libzypp default.
Testing
#[cfg(not(ci))]env: RUSTFLAGS: --cfg ciDocumentation
No change: working without crashing is not a special case.